After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749685 - places: Use a text title instead of a switcher when there is only one page
places: Use a text title instead of a switcher when there is only one page
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-05-21 15:46 UTC by Debarshi Ray
Modified: 2015-05-25 11:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
places: Don't use a switcher when there is only one page (1.43 KB, patch)
2015-05-21 15:48 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2015-05-21 15:46:26 UTC
In bug 741780 we hid the "contents" tab when the document doesn't have an index, which is quite common. We should use a simple text title instead of a GtkStackSwitcher with a single button when this happens.

I initially thought about implementing this behaviour in gtk+ itself, but then changed my mind. It doesn't appear generic enough to warrant the added complexity in GtkStackSwitcher.
Comment 1 Debarshi Ray 2015-05-21 15:48:52 UTC
Created attachment 303767 [details] [review]
places: Don't use a switcher when there is only one page
Comment 2 Debarshi Ray 2015-05-25 11:31:32 UTC
Comment on attachment 303767 [details] [review]
places: Don't use a switcher when there is only one page

I pushed it to master for today's 3.17.2 release.