After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749595 - Add support for libsystemd
Add support for libsystemd
Status: RESOLVED FIXED
Product: gnome-logs
Classification: Other
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-logs maintainer(s)
gnome-logs maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-05-19 18:17 UTC by Michael Biebl
Modified: 2015-05-22 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update configure.ac to check for libsystemd (906 bytes, patch)
2015-05-22 10:08 UTC, Rashi Aswani
committed Details | Review

Description Michael Biebl 2015-05-19 18:17:13 UTC
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=779768

In systemd v209, released over a year ago, the various libsystemd-* libraries
(libsystemd-journal.so, libsystemd-login.so, libsystem-daemon.so,
libsystemd-id128.so) were merged into a single libsystemd.so library to reduce
code duplication and avoid cyclic dependencies [1].

The patch can be as simple as

diff --git a/configure.ac b/configure.ac
index 1f051ec..2599aa2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -101,8 +101,8 @@ AM_CONDITIONAL([LOGS_ENABLE_TESTS], [test "x$testing_utilities" = "xyes"])
 dnl Libraries
 GIO_REQUIRED="gio-unix-2.0 >= 2.43.90"
 GTK_REQUIRED="gtk+-3.0 >= 3.15.7"
-SYSTEMD_JOURNAL_REQUIRED="libsystemd-journal"
-PKG_CHECK_MODULES([LOGS], [$GIO_REQUIRED $GTK_REQUIRED $SYSTEMD_JOURNAL_REQUIRED])
+SYSTEMD_REQUIRED="libsystemd"
+PKG_CHECK_MODULES([LOGS], [$GIO_REQUIRED $GTK_REQUIRED $SYSTEMD_REQUIRED])


If you want to support systemd versions <= 208, you'll need to add a fallback check.

For this you'll need to do the pkg-config check for libsystemd separately, like:

PKG_CHECK_MODULES([SYSTEMD], [libsystemd],,
                  [PKG_CHECK_MODULES([SYSTEMD], [libsystemd-journal])])



[1] http://lists.freedesktop.org/archives/systemd-devel/2014-February/017146.html
Comment 1 Rashi Aswani 2015-05-22 10:08:27 UTC
Created attachment 303807 [details] [review]
Update configure.ac to check for libsystemd
Comment 2 David King 2015-05-22 10:12:57 UTC
Review of attachment 303807 [details] [review]:

Looks good, please push to master.
Comment 3 Rashi Aswani 2015-05-22 12:32:24 UTC
Pushed to master in commit b55281240cd5624cb122329cb73dff92f212480b