GNOME Bugzilla – Bug 749489
[PATCH] Missing folder icons in file chooser on Win32
Last modified: 2015-07-08 03:07:01 UTC
Created attachment 303470 [details] [review] Fix display of folder icons on Win32 Prior to commit aa4e2d4dc313, the content type for a directory was hard-coded to "inode/directory". This assumption is no longer valid; in fact, directories no longer have any content type on Windows (g_file_info_get_content_type() returns null). This change broke the icon logic for directories in glocalfileinfo.c, causing folders to show up in the GTK+ file chooser with either a "generic file" icon or none at all. The attached patch fixes the issue by not assuming that the content type of directories will be any specific string. Instead, it activates the icon logic for directories whenever indicated by S_ISDIR.
Hi, Tested on fedora 22 mingw packages and work. Please, Apply this and backport to Glib 2.44.
There's newer commits that should already fix this. See https://git.gnome.org/browse/glib/commit/?id=5f0665cbbc1d8b2fafeeb1fba7569612832b7541
Yes, 5f0665cbbc1d is a simpler way to fix this. I thought about doing that myself but wasn't sure if it was okay to use the MIME-type as the GContentType, since that is not the convention on Windows. Seems there was some discussion about this and the consensus was: yes, it's okay. So I am happy to consider the issue resolved. *** This bug has been marked as a duplicate of bug 748727 ***