GNOME Bugzilla – Bug 749454
Ability to open a link into a new private window
Last modified: 2015-06-04 15:32:49 UTC
When right-clicking a link, I can open in a New tab, New window, but not "New private window" like other browsers allow me to. I would like to have that feature. I often use that to check out some profiles or pages on social networks without leaving a trace from my profile—an "opt out" so to speak.
Created attachment 304434 [details] [review] window: add a popup command to open links in incognito window
Created attachment 304446 [details] [review] file-helpers: add helper to launch a incognito window
Created attachment 304447 [details] [review] window: add a popup command to open links in incognito window
Both look good to me. Maybe Carlos will want to review.
Review of attachment 304446 [details] [review]: LGTM, but I don't see why this is in file-helpers, though.
Review of attachment 304447 [details] [review]: ::: src/popup-commands.c @@ +378,3 @@ + + event = ephy_window_get_context_event (window); + g_return_if_fail (event != NULL); We should stop doing this. If this is not expected to be null, use an assert, otherwise use an early return. g_return_if_fail macros can be disabled. @@ +381,3 @@ + + ephy_embed_event_get_property (event, "link-uri", &value); + address = g_value_get_string (&value); Since g_value_get_string() returns a const char, we don't really need the local var. @@ +382,3 @@ + ephy_embed_event_get_property (event, "link-uri", &value); + address = g_value_get_string (&value); + ephy_open_incognito_window (address); You are leaking the string, call g_value_unset() here.
(In reply to Carlos Garcia Campos from comment #5) > Review of attachment 304446 [details] [review] [review]: > > LGTM, but I don't see why this is in file-helpers, though. Any suggestion, where should it go?
Attachment 304446 [details] pushed as 5bbb98c - file-helpers: add helper to launch a incognito window Attachment 304447 [details] pushed as c54d16d - window: add a popup command to open links in incognito window
BTW, I made it so that the menu item is hidden if already in Incognito mode.