After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749425 - Memory leak in GtkWindow
Memory leak in GtkWindow
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.17.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-05-15 12:39 UTC by Kjell Ahlstedt
Modified: 2015-05-15 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch: gtkwindow: Fix a memory leak (901 bytes, patch)
2015-05-15 13:43 UTC, Kjell Ahlstedt 		committed Details | Review

Description Kjell Ahlstedt 2015-05-15 12:39:27 UTC 
In commit https://git.gnome.org/browse/gtk+/commit/?id=13e22e20300b7312e52bba7d077fc7e231695fc1
Carlos Garnacho added the GtkGesture* drag_gesture to GtkWindow's private data.
That GtkGesture instance is never deleted. It's a memory leak.

I suppose it shall be unref'ed in gtk_window_finalize(), just like
multipress_gesture is.
Comment 1 Kjell Ahlstedt 2015-05-15 13:43:23 UTC 
Created attachment 303425 [details] [review]
patch: gtkwindow: Fix a memory leak
Comment 2 Emmanuele Bassi (:ebassi) 2015-05-15 13:55:11 UTC 
Review of attachment 303425 [details] [review]:

Yep, looks good.