Bug 749421 – validate: avoid use of gdk_event_get_event_type() which requires GTK+ >= 3.10

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 749421 - validate: avoid use of gdk_event_get_event_type() which requires GTK+ >= 3.10


Summary:	validate: avoid use of gdk_event_get_event_type() which requires GTK+ >= 3.10

Attachments
Use gtk >= 3.10 for gtk plugins (870 bytes, patch) 2015-05-15 10:47 UTC, Young Han Lee	rejected	Details \| Review
validate:gtk: Use event->type directly (1.29 KB, patch) 2015-05-15 10:58 UTC, Thibault Saunier	accepted-commit_now	Details \| Review

Description Young Han Lee 2015-05-15 10:46:06 UTC

Building gst-devtools with gtk < 3.10 fails, because gdk_event_get_event_type is supported from gdk 3.10.

Comment 1 Young Han Lee 2015-05-15 10:47:14 UTC

Created attachment 303414 [details] [review]
Use gtk >= 3.10 for gtk plugins

Check gtk >= 3.10

Comment 2 Thibault Saunier 2015-05-15 10:58:09 UTC

Created attachment 303416 [details] [review]
validate:gtk: Use event->type directly

gdk_event_get_event_type was introduced in Gtk 3.10 only

Comment 3 Thibault Saunier 2015-05-15 11:01:34 UTC

Thanks for the report.

Using that method is clearly not mandatory for us so could you please check that fix is enough please? :)

Comment 4 Young Han Lee 2015-05-15 11:20:55 UTC

I just confirmed that gst-devtools is compiled properly on gtk 3.4.2 with only your patch.

Great. :)

Comment 5 Thibault Saunier 2015-05-18 08:17:37 UTC

Attachment 303416 [details] pushed as 4829e44 - validate:gtk: Use event->type directly