GNOME Bugzilla – Bug 749315
funnel: Add "forward-sticky-events" property
Last modified: 2015-09-22 07:51:34 UTC
I propose deleting the funnel from dtlssrtpenc. Reasons: - funnel sends all sticky events again on stream changes, which adds an high overhead. - If the user want to merge into a single stream, he can use a funnel connected to the output of the dtlssrtpenc, so he has the same current behaviour. - Having separated pads is useful for connecting different elements for each srcpad, testing, etc. Related with https://bugzilla.gnome.org/show_bug.cgi?id=748723
Don't you always have to merge the output anyway to send it over the network?
I am using in the way you say, but the important thing is the overhead added on stream changes. So, we are planning to create a "litefunnel" to avoid sending all sticky events.
Why not just add a property to funnel ?
Yeah, it is a good idea ;). It will be easier to use for other users without changing their current implementations. How can we call this property? And an important point: we should doc about possible inconvenients of not sending the sticky events.
Also a funnel like that would be the right thing to do for dtlssrtpenc anyway. It should output DTLS caps and a single stream, from the outside it shouldn't look like separate streams at all. It's just like a muxer here.
Maybe call that property forward-sticky-events and put it on the sinkpads of funnel. If set to false, no sticky events of that pad are forwarded when it becomes active. What do you think?
I prefer and easier way. So I am uploading a patch that adds the property you suggested but is used for all pads.
Created attachment 303356 [details] [review] 0001-funnel-add-forward-sticky-events-property.patch
I think a per-pad property would be more useful. Especially your patch now will stop funnel from sending any sticky events, making data flow wrong because of missing stream-start/segment events. It should somehow invent the events then. With the per-pad approach you could pass through the events of a single pad as needed.
Created attachment 306001 [details] [review] 0001-funnel-add-forward-sticky-events-property.patch
Let's add the per-pad property at a later time when needed. Now only this property has to be used by elements. commit c2e15651beca382245fee9935ef81c1b6620fd0f Author: Miguel París Díaz <mparisdiaz@gmail.com> Date: Thu May 14 11:48:45 2015 +0200 funnel: add "forward-sticky-events" property It is useful to avoid sending sticky event on stream changes. https://bugzilla.gnome.org/show_bug.cgi?id=749315
I agree, my point of view was the same ;).