After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749192 - xml dep: first check for /etc/xml/catalog
xml dep: first check for /etc/xml/catalog
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other OpenBSD
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2015-05-10 10:42 UTC by Antoine Jacoutot
Modified: 2015-06-14 07:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
reverse XML docbook catalog check (1.52 KB, patch)
2015-05-28 07:53 UTC, Antoine Jacoutot
accepted-commit_now Details | Review

Description Antoine Jacoutot 2015-05-10 10:42:25 UTC
Hi.

This commit:
https://git.gnome.org/browse/jhbuild/commit/jhbuild/utils/systeminstall.py?id=cb76d6809ac9390faa06eec36887293026bd6ffd
introduced a check for "xml" system dependencies.

Unfortunately, that prevents docbook-xml from being properly detected as installed on OpenBSD.
The reason is that we have this file:
$ cat /usr/local/share/xml/catalog
CATALOG "docbook/catalog"
which is not a proper xml catalog of course (just an "include this dir" configuration).

The "correct" xml catalog is under /etc/xml/catalog on OpenBSD (and some other Linux distros as well afaict; except they don't have /usr/share/xml/catalog so they don't run into the same issue as ours).
Would it be alright to reverse the logic? That is check for /etc/xml/catalog first and then fallback to XDG_DATA_DIRS/share/catalog?

I can provide a patch for that but first I wanted to make sure that's a direction that GNOME developers agree on.

Thanks.
Comment 1 Antoine Jacoutot 2015-05-27 12:55:25 UTC
Hi.

Any feedback on this?
Thanks.
Comment 2 Frederic Peters 2015-05-27 13:09:57 UTC
Sorry about that; I'm fine putting /etc/xml/catalog first.
Comment 3 Antoine Jacoutot 2015-05-28 07:53:55 UTC
Created attachment 304128 [details] [review]
reverse XML docbook catalog check

Awesome Frederic, thanks.
Let me know if it's ok to push this.
Comment 4 Antoine Jacoutot 2015-06-14 07:08:56 UTC
Hi Frederic.

Any comment about that patch?
Thanks.
Comment 5 Frederic Peters 2015-06-14 07:30:43 UTC
Comment on attachment 304128 [details] [review]
reverse XML docbook catalog check

ok.
Comment 6 Antoine Jacoutot 2015-06-14 07:44:07 UTC
It's in, thanks a lot :-)