After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749107 - codec-utils: add a gst_codec_utils_aac_get_channels
codec-utils: add a gst_codec_utils_aac_get_channels
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.4.5
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-08 13:06 UTC by Jimmy Ohn
Modified: 2016-03-24 13:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
codec-utils: add a gst_codec_utils_aac_get_channels (3.30 KB, patch)
2015-05-08 13:44 UTC, Jimmy Ohn 		none Details | Review
codec-utils: add a gst_codec_utils_aac_get_channels (3.39 KB, patch)
2015-05-28 14:06 UTC, Jimmy Ohn 		rejected Details | Review

Description Jimmy Ohn 2015-05-08 13:06:11 UTC 
To remove the FIXME in the qtdemux, I add this function.
Comment 1 Jimmy Ohn 2015-05-08 13:43:07 UTC 
This is the related qtdemux patch. you can check below url.
https://bugzilla.gnome.org/show_bug.cgi?id=749110
Comment 2 Jimmy Ohn 2015-05-08 13:44:27 UTC 
Created attachment 303077 [details] [review]
codec-utils: add a gst_codec_utils_aac_get_channels
Comment 3 Jimmy Ohn 2015-05-28 14:06:50 UTC 
Created attachment 304166 [details] [review]
codec-utils: add a gst_codec_utils_aac_get_channels
Comment 4 Sebastian Dröge (slomo) 2016-03-21 08:51:50 UTC 
Please merge this with the other bug, and the patch that adds the sample rate function.
Comment 5 Sebastian Dröge (slomo) 2016-03-21 08:53:31 UTC 
Review of attachment 304166 [details] [review]:

::: gst-libs/gst/pbutils/codec-utils.c
@@ +114,3 @@
+ * Returns the channels of the given AAC stream.
+ *
+ * Returns: The channels and 0 if the channel could not be determined.

s/and/or/

"... if *the number of channels* could ..."

@@ +116,3 @@
+ * Returns: The channels and 0 if the channel could not be determined.
+ *
+ * Since 1.6

We're at 1.10 now
Comment 6 Jimmy Ohn 2016-03-22 02:43:53 UTC 
I've merge patches at below link.
https://bugzilla.gnome.org/show_bug.cgi?id=749110