After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749105 - videoconvert: Expose some properties from the videoconverter API
videoconvert: Expose some properties from the videoconverter API
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-08 12:30 UTC by Vivia Nikolaidou
Modified: 2015-05-08 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch file. (7.38 KB, patch)
2015-05-08 12:30 UTC, Vivia Nikolaidou 		none Details | Review
Patch file, also exposing alpha value. (8.04 KB, patch)
2015-05-08 13:16 UTC, Vivia Nikolaidou 		committed Details | Review

Description Vivia Nikolaidou 2015-05-08 12:30:30 UTC 
Created attachment 303072 [details] [review]
Patch file.

Expose chroma resampler, alpha mode, chroma mode, matrix mode, gamma mode and
primaries mode from the videoconverter API.
Comment 1 Sebastian Dröge (slomo) 2015-05-08 12:36:51 UTC 
Review of attachment 303072 [details] [review]:

Looks good :)

::: gst/videoconvert/gstvideoconvert.c
@@ +60,3 @@
 #define DEFAULT_PROP_DITHER_QUANTIZATION 1
+#define DEFAULT_PROP_CHROMA_RESAMPLER	GST_VIDEO_RESAMPLER_METHOD_LINEAR
+#define DEFAULT_PROP_ALPHA_MODE GST_VIDEO_ALPHA_MODE_COPY

If you expose the alpha mode, you should also expose the alpha value
Comment 2 Vivia Nikolaidou 2015-05-08 13:16:26 UTC 
Created attachment 303074 [details] [review]
Patch file, also exposing alpha value.
Comment 3 Sebastian Dröge (slomo) 2015-05-08 13:17:52 UTC 
commit 327efa9805606339714e73948b876e696188a9c8
Author: Vivia Nikolaidou <vivia@ahiru.eu>
Date:   Fri May 8 15:21:16 2015 +0300

    videoconvert: Expose some properties from the videoconverter API
    
    Expose chroma resampler, alpha mode, alpha value, chroma mode, matrix mode,
    gamma mode and primaries mode from the videoconverter API.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=749105