After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748911 - [PATCH] Make generation of cairo-perl-auto.typemap and cairo-perl-auto.h deterministic
[PATCH] Make generation of cairo-perl-auto.typemap and cairo-perl-auto.h dete...
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Cairo
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2015-05-04 17:57 UTC by intrigeri
Modified: 2015-08-24 19:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Generate cairo-perl-auto.typemap and cairo-perl-auto.h in a deterministic fashion (2.23 KB, patch)
2015-05-04 17:57 UTC, intrigeri 		committed Details | Review

Description intrigeri 2015-05-04 17:57:44 UTC 
Created attachment 302891 [details] [review]
Generate cairo-perl-auto.typemap and cairo-perl-auto.h in a deterministic fashion

Hi,

while working on the "reproducible builds" effort (https://wiki.debian.org/ReproducibleBuilds) we've identified that perl-Cairo did not build in a reproducible way, since cairo-perl-auto.typemap and cairo-perl-auto.h are auto-generated by iterating over hash keys.

The attached patch fixes this by sorting hash keys used when generating these files. Please consider for inclusion upstream.

Thanks!
Comment 1 Torsten Schoenfeld 2015-08-24 19:19:06 UTC 
Looks good, committed.  Thanks for the patch!