missing attachment?

Created attachment 302911 [details] [review]
jpegdec: fix frame leaks in handle_frame() implementation

handle_frame() is supposed to consume @frame, so if we don't call
gst_video_decoder_drop_frame() or gst_video_decoder_finish_frame() we have to
unref it manually.

Review of attachment 302911 [details] [review]:

::: ext/jpeg/gstjpegdec.c
@@ +1154,3 @@
 
+  if (unref_frame)
+    gst_video_codec_frame_unref (frame);

I think the correct call is gst_video_decoder_release_frame(), so it also get removed from the base class internal list. Please verify.

Yep, looks like you're right.

Created attachment 302938 [details] [review]
jpegdec: fix frame leaks in handle_frame() implementation

handle_frame() is supposed to consume @frame, so if we don't call
gst_video_decoder_drop_frame() or gst_video_decoder_finish_frame() we have to
release it manually.

Review of attachment 302938 [details] [review]:

Looks good.

Attachment 302938 [details] pushed as 1421fc5 - jpegdec: fix frame leaks in handle_frame() implementation

Review of attachment 302938 [details] [review]:

.