GNOME Bugzilla – Bug 748877
theoraenc regression
Last modified: 2015-08-11 14:13:26 UTC
Created attachment 302843 [details] file that show the issue please try this pipeline with the attached file: gst-launch-1.0 -v filesrc location=/tmp/test.mkv ! matroskademux ! avdec_h264 ! videoconvert ! theoraenc ! fakesink silent=false it works in 1.4 but not in git master, if you change theoraenc with vp8enc, jpegenc ecc.. it works in git master too
reporting here and not in a separate bug since could be related (and maybe not so theora specific), same file, try this pipeline: gst-launch-1.0 -v filesrc location=/tmp/test.mkv ! matroskademux ! avdec_h264 ! queue ! vp8enc ! oggmux ! filesink location=/tmp/test.ogg 1.4 works git master produce a 54 bytes files (only ogg header)
This is caused by your patch: commit c466ff474859cce91e9dd9b906c48f5fe0c4b164 Author: Nicola Murino <nicola.murino@gmail.com> Date: Tue Nov 18 16:52:40 2014 +0100 matroskademux: set framerate 0/1 when duration is not known https://bugzilla.gnome.org/show_bug.cgi?id=740130 Ogg wants a fixed framerate for video input, so you need to put a videorate before it. I don't think theoraenc's sink pad template is entirely right, I think it should accept 0/1 framerates (for cases like RTP), and oggmux should then advertise non-0/1 framerates. In any case, this has likely led to broken video even before your patch, so it needs to be fixed in your app/pipeline IMHO.
Theora currently also advertises only non-0/1 framerates, that's why it fails with not-linked in the ... ! theoraenc ! fakesink case.
Thanks for pointing it out, I modified my app to add a videorate for theora and ogg case, I still have some problems with oggmux (the effective fps seems lesser than the one requested), but eventually I'll report them separately, for me this bug can be closed
commit 741d23f06ced5759732b48e72a0b4cd57f71141d Author: Tim-Philipp Müller <tim@centricular.com> Date: Tue Aug 11 15:09:10 2015 +0100 theoraenc: mention videorate is often needed in docs https://bugzilla.gnome.org/show_bug.cgi?id=748877