GNOME Bugzilla – Bug 748849
power: Save last requested idle mode while temporarily unidle
Last modified: 2015-05-04 13:37:06 UTC
This prevents the following bug: 1. Laptop enters sleep 2. Lid open, wake up, idle time gets reset, we enter NORMAL state 3. There's a notification so gnome-shell asks us to go temporarily unidle while we're in NORMAL state 4. The 15s inactivity watch is triggered and we switch to BLANK 5. The unidle timer is triggered and we switch back to NORMAL since that's the state we were in when it started Result is that the screen is left turned ON indefinitely after waking from sleep if there's a notification when we wake up.
Created attachment 302816 [details] [review] power: Save last requested idle mode while temporarily unidle If one of our idle watches triggers while we're temporarily unidle we should save and switch to it when that period ends otherwise we would ignore any idle request transitions in that period and always go back to the state where we were when becoming temporarily unidle.
Review of attachment 302816 [details] [review]: Looks good though I would include the reproducer in the commit message. Should also look into whether a test suite addition is possible.
7f31d00..82e66ef gnome-3-14 -> gnome-3-14 9ac05a2..b98655a master -> master Attachment 302816 [details] pushed as b98655a - power: Save last requested idle mode while temporarily unidle
(In reply to Bastien Nocera from comment #2) > Looks good though I would include the reproducer in the commit message. Done. > Should also look into whether a test suite addition is possible. Filed bug 748890 for that.