After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748614 - Double unref in g_socket_listener_add_inet_port
Double unref in g_socket_listener_add_inet_port
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: network
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-04-29 07:16 UTC by Ting-Wei Lan
Modified: 2015-05-01 15:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gsocketlistener: Don't double unref address (896 bytes, patch)
2015-04-29 07:19 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2015-04-29 07:16:51 UTC 
The socket option IPV6_V6ONLY is set to 1 by default on FreeBSD, so g_socket_listener_add_inet_port opens both IPv6 and IPv4 sockets. The address object in need_ipv4_socket block is double unref-ed, which causes broadwayd to crash on FreeBSD.
Comment 1 Ting-Wei Lan 2015-04-29 07:19:08 UTC 
Created attachment 302542 [details] [review]
gsocketlistener: Don't double unref address
Comment 2 Ting-Wei Lan 2015-05-01 15:12:03 UTC 
Attachment 302542 [details] pushed as 517ce45 - gsocketlistener: Don't double unref address