After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748563 - videobufferpool: Free members before chaining up finalize
videobufferpool: Free members before chaining up finalize
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 743569
 
 
Reported: 2015-04-28 02:11 UTC by Olivier Crête
Modified: 2015-04-28 09:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videobufferpool: Free members before chaining up finalize (1.09 KB, patch)
2015-04-28 02:11 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2015-04-28 02:11:36 UTC 
Created attachment 302490 [details] [review]
videobufferpool: Free members before chaining up finalize

The finalize function in GObject frees the object memory, so everything else needs to have been freed before, otherwise they may be leaked.
Comment 1 Gwenole Beauchesne 2015-04-28 08:25:51 UTC 
Review of attachment 302490 [details] [review]:

LGTM, but how can the patch comment hold in practice? I mean, the objects are ref-counted, and the base object has no clue about them, and if it had, then that would be ref-counted too, isn't it?

Anyway, that's fine to commit that patch.
Comment 2 Gwenole Beauchesne 2015-04-28 08:25:52 UTC 
Review of attachment 302490 [details] [review]:

LGTM, but how can the patch comment hold in practice? I mean, the objects are ref-counted, and the base object has no clue about them, and if it had, then that would be ref-counted too, isn't it?

Anyway, that's fine to commit that patch.
Comment 3 Víctor Manuel Jáquez Leal 2015-04-28 09:21:17 UTC 
Comment on attachment 302490 [details] [review]
videobufferpool: Free members before chaining up finalize

commit be37f459986ca7144643d4570482773909d067cf 
Author: Olivier Crete <olivier.crete@collabora.com>
Date:   Mon Apr 27 20:50:19 2015 -0400

    videopool: Free members before chaining up finalize
    
    The finalize function in GObject frees the object memory, so
    everything else needs to have been freed before.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748563