After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748541 - events: Ignore some event types when reseting idle time
events: Ignore some event types when reseting idle time
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-04-27 17:12 UTC by Rui Matos
Modified: 2015-04-27 17:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
events: Ignore some event types when reseting idle time (1.15 KB, patch)
2015-04-27 17:12 UTC, Rui Matos
committed Details | Review
shell-global: Mark the sync pointer motion event as synthetic (871 bytes, patch)
2015-04-27 17:12 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2015-04-27 17:12:22 UTC
These events don't result from actual hardware events so we shouldn't
use them to reset idle time.
Comment 1 Rui Matos 2015-04-27 17:12:27 UTC
Created attachment 302466 [details] [review]
events: Ignore some event types when reseting idle time
Comment 2 Rui Matos 2015-04-27 17:12:57 UTC
Created attachment 302467 [details] [review]
shell-global: Mark the sync pointer motion event as synthetic

This allows mutter to ignore these events for the purpose of keeping
idle time.
Comment 3 Jasper St. Pierre (not reading bugmail) 2015-04-27 17:14:58 UTC
Review of attachment 302466 [details] [review]:

Fine by me.
Comment 4 Rui Matos 2015-04-27 17:15:06 UTC
Running native, when the screen locks we would enter DPMS and immediately come out of it due to this:

== Stack trace for context 0x3205120 ==
AltSwitcher<._sync@resource:///org/gnome/shell/ui/status/system.js:64
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
Indicator<._updatePowerOff@resource:///org/gnome/shell/ui/status/system.js:270
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
Indicator<._sessionUpdated@resource:///org/gnome/shell/ui/status/system.js:175
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
_emit@resource:///org/gnome/gjs/modules/signals.js:124
SessionMode<._sync@resource:///org/gnome/shell/ui/sessionMode.js:205
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
SessionMode<.pushMode@resource:///org/gnome/shell/ui/sessionMode.js:167
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
ScreenShield<.activate@resource:///org/gnome/shell/ui/screenShield.js:1249
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
ScreenShield<.lock@resource:///org/gnome/shell/ui/screenShield.js:1290
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
@resource:///org/gnome/shell/ui/screenShield.js:810
Comment 5 Jasper St. Pierre (not reading bugmail) 2015-04-27 17:15:08 UTC
Review of attachment 302467 [details] [review]:

Good idea.
Comment 6 Rui Matos 2015-04-27 17:46:29 UTC
Comment on attachment 302466 [details] [review]
events: Ignore some event types when reseting idle time

c99da71..7bdd698  gnome-3-16 -> gnome-3-16
   dd3cf94..d62c595  master -> master

Attachment 302466 [details] pushed as d62c595 - events: Ignore some event types when reseting idle time
Comment 7 Rui Matos 2015-04-27 17:48:29 UTC
ed6cb19..f8eb9e7  gnome-3-16 -> gnome-3-16
   0e6baec..4f70301  master -> master

Attachment 302467 [details] pushed as 4f70301 - shell-global: Mark the sync pointer motion event as synthetic