After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748511 - [PATCH] applet: don't crash if an agent is already registered
[PATCH] applet: don't crash if an agent is already registered
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2015-04-27 09:12 UTC by Lubomir Rintel
Modified: 2015-04-28 10:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
applet: don't crash if an agent is already registered (1.50 KB, text/plain)
2015-04-27 09:12 UTC, Lubomir Rintel
Details

Description Lubomir Rintel 2015-04-27 09:12:38 UTC
Created attachment 302414 [details]
applet: don't crash if an agent is already registered

GNOME 3.16 makes it possible to run the legacy applets again, making it
possible to develop & debug the applet there. Unfortunately, we crash -- GNOME
registers its own secret agent.

Moreover the error handling in libnm (as of post-1.0 master) is broken. A
separate commit to daemon will address that. For now let's just avoid crashing
and produce a warning message.
---
 src/applet.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
Comment 1 Dan Williams 2015-04-27 19:03:49 UTC
LGTM
Comment 2 Lubomir Rintel 2015-04-28 10:36:21 UTC
b458df8 applet: don't crash if an agent is already registered