After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748346 - build: Avoid xgettext crash on MSYS2
build: Avoid xgettext crash on MSYS2
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-04-23 01:00 UTC by Daiki Ueno
Modified: 2015-04-27 10:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Avoid xgettext crash on MSYS2 (1.35 KB, patch)
2015-04-23 01:00 UTC, Daiki Ueno 		committed Details | Review

Description Daiki Ueno 2015-04-23 01:00:14 UTC 
isatty() on MSYS2 returns non-zero if the fd is stdout and is redirected
to /dev/null.  That lets xgettext to produce colorized output and leads
to an assertion failure during terminal type detection.

Although the problem should be fixed in MSYS2, isatty() could behave
wrongly in many ways on Windows.  Since gtk+ doesn't need colorized
output, it would be safer to bypass the terminal dependent code.

See also:
https://lists.gnu.org/archive/html/bug-gettext/2015-04/msg00004.html
Comment 1 Daiki Ueno 2015-04-23 01:00:18 UTC 
Created attachment 302192 [details] [review]
build: Avoid xgettext crash on MSYS2
Comment 2 Matthias Clasen 2015-04-27 10:31:18 UTC 
Attachment 302192 [details] pushed as b10d63c - build: Avoid xgettext crash on MSYS2