GNOME Bugzilla – Bug 748328
W32: GDK backend does some unnecessary hashmap lookups
Last modified: 2018-04-15 00:17:09 UTC
Some of them are completely unnecessary (objects are already available). Others can be sometimes skipped by using heuristics.
Created attachment 302181 [details] [review] W32: Minor mouse message processing optimization * Don't call gdk_display_get_device_manager() and _gdk_display_get_last_device_grab(), we already have device_manager_win32 and pointer_grab * Give the window we already found from msg->hwnd to the window finder, don't perform another lookup if hwnd is the same
Review of attachment 302181 [details] [review]: First thing. From reading the commit message this should be split in 2 commits. Can you do that?
(In reply to Ignacio Casal Quinteiro (nacho) from comment #2) > Review of attachment 302181 [details] [review] [review]: > > First thing. From reading the commit message this should be split in 2 > commits. Can you do that? No. They modify the same function in a similar way (give it existing object to reduce the number of lookups).
attachment 302181 [details] [review] is now merged into the patch in bug 748325
We're moving to gitlab! As part of this move, we are moving bugs to NEEDINFO if they haven't seen activity in more than a year. If this issue is still important to you and still relevant with GTK+ 3.22 or master, please reopen it and we will migrate it to gitlab.
As announced a while ago, we are migrating to gitlab, and bugs that haven't seen activity in the last year or so will be not be migrated, but closed out in bugzilla. If this bug is still relevant to you, you can open a new issue describing the symptoms and how to reproduce it with gtk 3.22.x or master in gitlab: https://gitlab.gnome.org/GNOME/gtk/issues/new