After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748220 - Detached metadata updates not fetched
Detached metadata updates not fetched
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
2014.4
Other Linux
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-04-20 23:12 UTC by Matthew Barnes
Modified: 2015-04-23 23:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Matthew Barnes 2015-04-20 23:12:03 UTC 
In working on GPG features for OSTree there's been a few occasions where I've forgotten to sign a newly-composed tree before pulling from an atomic host.

If GPG verification is enabled on the OSTree remote, this isn't a problem because the pull fails until I sign the tree.  But otherwise the pull completes.

If I then sign the commit and pull again with GPG verification disabled, the new signatures are never fetched because as far as the client-side can tell it's up-to-date.

Perhaps more generally, detached metadata updates are not detected during pulls.

Should they be?  It seems so, at least in the GPG case.

I know detached metadata doesn't figure into commit checksums, and it would be premature to suggest a solution since I'm still grokking the details of pulls.

What are your thoughts?  Legit bug?
Comment 1 Colin Walters 2015-04-21 00:54:32 UTC 
I'd say let's re-fetch detached metadata on every pull request.

(If we wanted to optimize things slightly we could start to implement proper caching by recording ETag/If-Modified-Since and such, but eh..it's going to be small).
Comment 2 Matthew Barnes 2015-04-21 01:25:21 UTC 
Sounds easy enough.  I'll cook up a patch.
Comment 3 Matthew Barnes 2015-04-21 23:37:40 UTC 
https://github.com/GNOME/ostree/pull/94