After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748085 - [review] dcbw/rh1207730-rdisc-fixes: fix router solicitation loop
[review] dcbw/rh1207730-rdisc-fixes: fix router solicitation loop
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: IP and DNS config
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2015-04-17 21:43 UTC by Dan Williams
Modified: 2015-05-01 21:37 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dan Williams 2015-04-17 21:43:47 UTC
A solicitation loop could result for two cases:

1) a router sent DNS information, then removed that information without
sending it with lifetime=0
2) two routers exist, one sending DNS information and the other not, and
the first router which sends DNS information disappears

In these cases a solicitation would be generated when the DNS information
reached 1/2 its lifetime.  A router would then reply to the solicitation
without DNS information, which would then trigger another lifetime check,
which finds that the DNS info is still 1/2 lifetime.  Which triggers
another solicitation, etc.

Fix this by ensuring that a solicitation is never sent less than
rtr_solicitation_interval seconds after the last one.
Comment 1 Thomas Haller 2015-04-20 09:33:09 UTC
It's based on nm-1-0 branch. Is that on purpose?
Comment 2 Dan Williams 2015-04-21 18:41:34 UTC
(In reply to Thomas Haller from comment #1)
> It's based on nm-1-0 branch. Is that on purpose?

Yeah, because I first did the patches for RHEL.  I'll forward-port to git master when it's all reviewed; I don't expect any difficulties there since this is all confined to rdisc/ which hasn't changed much.
Comment 3 Dan Williams 2015-05-01 21:37:35 UTC
Merged to git master and nm-1-0