After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748024 - icydemux: Fix segfault for 0-value metainterval
icydemux: Fix segfault for 0-value metainterval
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-17 07:14 UTC by Alex O'Konski
Modified: 2015-04-17 09:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
prepared commit (1.04 KB, patch)
2015-04-17 07:16 UTC, Alex O'Konski 		committed Details | Review

Description Alex O'Konski 2015-04-17 07:14:09 UTC 
Prevents an extra unref of GstBuffer when passing a non-icy stream through
icydemux with metadata-interval set to 0.

Reproducible with:
    gst-launch-1.0 filesrc location=~/testsong.mp3 ! 'application/x-icy,metadata-interval=(int)0' ! icydemux ! decodebin ! wavenc ! filesink location=~/testsong.wav
Comment 1 Alex O'Konski 2015-04-17 07:16:12 UTC 
Created attachment 301788 [details] [review]
prepared commit
Comment 2 Alex O'Konski 2015-04-17 07:31:06 UTC 
It looks like this bug goes back to the original commit of icydemux.
Comment 3 Tim-Philipp Müller 2015-04-17 09:04:53 UTC 
Thanks for the patch, pushed:

commit fc038f1f4e45c5c3eb9ba8261c4e0210dd125821
Author: Alex O'Konski <alexanderokonski@gmail.com>
Date:   Fri Apr 17 06:51:46 2015 +0000

    icydemux: Fix segfault if metadata-interval is 0
    
    Prevents an extra unref of GstBuffer when passing a non-icy stream through
    icydemux with metadata-interval set to 0.
    
    Reproducible with:
    gst-launch-1.0 filesrc location=~/testsong.mp3 ! \
    'application/x-icy,metadata-interval=(int)0' ! icydemux ! decodebin ! wavenc ! \
    filesink location=~/testsong.wav
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748024
Comment 4 Alex O'Konski 2015-04-17 09:23:53 UTC 
Thanks for the quick review!