After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747945 - vaapipostproc: Don't create filter on caps query
vaapipostproc: Don't create filter on caps query
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 743569
 
 
Reported: 2015-04-15 19:31 UTC by Olivier Crête
Modified: 2015-04-16 10:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
possible fix (2.21 KB, patch)
2015-04-15 19:31 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2015-04-15 19:31:46 UTC 
Created attachment 301679 [details] [review]
possible fix

The problem with this is that creating the filter causes the display to
be selected, and the caps query happens while linking the element. So,
if the downstream or upstream element is using a specific display
object, it won't be propagated correctly to the postproc as it already
has a display at this point.
Comment 1 Víctor Manuel Jáquez Leal 2015-04-16 10:52:25 UTC 
Comment on attachment 301679 [details] [review]
possible fix

commit 6f298f6182614cfaf9f3d043207ebe8a6141ffaf
Author: Olivier Crete <olivier.crete@collabora.com>
Date:   Wed Apr 15 15:26:12 2015 -0400

    vaapipostproc: Don't create filter on caps query
    
    The problem with this is that creating the filter causes the display to
    be selected, and the caps query happens while linking the element. So,
    if the downstream or upstream element is using a specific display
    object, it won't be propagated correctly to the postproc as it already
    has a display at this point.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=747945