After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747944 - videopool: Release lock while allocating new object
videopool: Release lock while allocating new object
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 743569
 
 
Reported: 2015-04-15 19:30 UTC by Olivier Crête
Modified: 2015-04-16 10:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (1.55 KB, patch)
2015-04-15 19:30 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2015-04-15 19:30:44 UTC 
Created attachment 301678 [details] [review]
fix

The video pool can be accessed with the display lock held, for example,
when releasing a buffer from inside vaapisink_render, but allocating
a new object can may also take the display lock. Which means a possible
deadlock.
Comment 1 Víctor Manuel Jáquez Leal 2015-04-16 10:24:54 UTC 
Comment on attachment 301678 [details] [review]
fix

commit 0adb36b6587b099724453bc4ef0aafb1b65a392f
Author: Olivier Crete <olivier.crete@collabora.com>
Date:   Wed Apr 15 15:20:17 2015 -0400

    videopool: Release lock while allocating new object
    
    The video pool can be accessed with the display lock held, for example,
    when releasing a buffer from inside vaapisink_render, but allocating
    a new object can may also take the display lock. Which means a possible
    deadlock.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=747944