After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747831 - fix HEVC compilation
fix HEVC compilation
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-04-14 08:21 UTC by Víctor Manuel Jáquez Leal
Modified: 2015-04-16 09:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: don't compile HEVC if not supported (3.22 KB, patch)
2015-04-14 08:21 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review
HEVC: silence the compiler (1.94 KB, patch)
2015-04-14 08:21 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description Víctor Manuel Jáquez Leal 2015-04-14 08:21:32 UTC 
The new HEVC support has couple issues: 

a) it doesn't check if the HEVC support is present in the installed libva.
b) there are a couple compiler warnings in the code.

I would like a quick review for the second patch, since it touches code that
I don't follow completely.
Comment 1 Víctor Manuel Jáquez Leal 2015-04-14 08:21:38 UTC 
Created attachment 301515 [details] [review]
build: don't compile HEVC if not supported

HEVC decoding was added recently libva-1.5.

This patch avoids HEVC decoding support in libgstvaapi if it is not available
in the installed libva.
Comment 2 Víctor Manuel Jáquez Leal 2015-04-14 08:21:43 UTC 
Created attachment 301516 [details] [review]
HEVC: silence the compiler

Fixed a couple of clang complains.
Comment 3 Víctor Manuel Jáquez Leal 2015-04-14 09:39:07 UTC 
commit 3eb7986409b900abf1261b8e94ad08afba69d1b6
Author: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Date:   Tue Apr 14 10:08:47 2015 +0200

    build: don't compile HEVC if not supported
Comment 4 Víctor Manuel Jáquez Leal 2015-04-16 09:39:14 UTC 
commit 8bef2cbd49ae44fa965366f9eabd8325112195d7
Author: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Date:   Tue Apr 14 10:17:16 2015 +0200

    HEVC: silence the compiler