After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747810 - Fix the build with GLib >= 2.45
Fix the build with GLib >= 2.45
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2015-04-13 23:40 UTC by Emmanuele Bassi (:ebassi)
Modified: 2015-04-14 09:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do not use intltool to translate GSettings schema (7.31 KB, patch)
2015-04-13 23:40 UTC, Emmanuele Bassi (:ebassi)
committed Details | Review

Description Emmanuele Bassi (:ebassi) 2015-04-13 23:40:13 UTC
The glib-compile-schemas tool has become more strict, and it's catching the mangling of gschema files that are getting translated via intltool by merging translations back into the XML. The resulting gschema file is not valid, and never has been, and it has caused bugs like dconf-editor showing random strings into the UI, instead of the correctly translated one.

The proper fix is to not have intltool extract the strings from the gschema.xml file: gettext is perfectly capable of doing that by itself.
Comment 1 Emmanuele Bassi (:ebassi) 2015-04-13 23:40:22 UTC
Created attachment 301497 [details] [review]
Do not use intltool to translate GSettings schema

There's no need to do that, and since intltool merges translations into
the XML by default, it actively breaks the gschema format.
Comment 2 Jonas Danielsson 2015-04-14 06:24:45 UTC
Review of attachment 301497 [details] [review]:

Thanks for doing this! Much appreciated!
So, is this needed for 3.16 or only 3.17?

Feel free to commit. Note that gnome-3-16 is branched of.

Thanks again.
Comment 3 Emmanuele Bassi (:ebassi) 2015-04-14 09:14:50 UTC
(In reply to Jonas Danielsson from comment #2)

> Thanks for doing this! Much appreciated!
> So, is this needed for 3.16 or only 3.17?

This is needed when compiling against current GLib master, so I think we can avoid backporting to the gnome-3-16 branch; I'd also avoid it because I'm not sure how well the tools we use for translations cope with that case.
Comment 4 Emmanuele Bassi (:ebassi) 2015-04-14 09:15:30 UTC
Attachment 301497 [details] pushed as 3903262 - Do not use intltool to translate GSettings schema