After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747808 - window: fix initial shadow width for maximized/fullscreen windows
window: fix initial shadow width for maximized/fullscreen windows
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-04-13 23:35 UTC by Cosimo Cecchi
Modified: 2015-04-17 02:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window: fix initial shadow width for maximized/fullscreen windows (1.65 KB, patch)
2015-04-13 23:35 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2015-04-13 23:35:07 UTC
See attached patch for details.
Comment 1 Cosimo Cecchi 2015-04-13 23:35:11 UTC
Created attachment 301495 [details] [review]
window: fix initial shadow width for maximized/fullscreen windows

To calculate the shadow width, we look at the value of priv->fullscreen
and priv->maximized.
Those fields will have the actual value only after GTK receives back a
window state event though, so they will be wrong in _realize(). Look at
priv->fullscreen_initially and priv->maximize_initially too, to avoid
the size changing right after realize, which would make the window
flicker if maximized at startup.
Comment 2 Matthias Clasen 2015-04-14 15:35:34 UTC
Review of attachment 301495 [details] [review]:

Good catch! But I'm a little worried that always looking at those initially bits might be risky, and maybe we should consider them only if !mapped.
Looking e.g. at gtk_window_maximize, we do set maximize_initially, regardless of whether we're already mapped or not.
Comment 3 Matthias Clasen 2015-04-17 02:26:17 UTC
Attachment 301495 [details] pushed as 740bcf5 - window: fix initial shadow width for maximized/fullscreen windows