Created attachment 301044 [details] [review]
InputSettings: apply mouse natural scroll settings at startup

Looks like it's also missing from _device_added() . Carlos, is there a reason for this?

Oops, not really, forgotten as Giovanni pointed out. I remember the natural scroll setting for non-touchpads was a "why not" afterthought, I didn't test as thoroughly as with touchpads apparently...

*** Bug 747838 has been marked as a duplicate of this bug. ***

Created attachment 301544 [details] [review]
input-settings: Ensure that we always apply the same set of settings

This makes the hotplug and coldplug paths the same so that we don't
miss out on any setting.
--

I think we should go with something like this to avoid further
mistakes.

*** Bug 747838 has been marked as a duplicate of this bug. ***

Comment on attachment 301544 [details] [review]
input-settings: Ensure that we always apply the same set of settings

Looks right to me. I'd perhaps change the

+      if (type == CLUTTER_POINTER_DEVICE)
+        enabled = g_settings_get_boolean (priv->mouse_settings, key);
+      else if (type == CLUTTER_TOUCHPAD_DEVICE)
+        enabled = g_settings_get_boolean (priv->touchpad_settings, key);

parts to use a get_settings_for_device() kind of function.

(In reply to Carlos Garnacho from comment #7)
> parts to use a get_settings_for_device() kind of function.

Ok, pushed with something along those lines. Thanks

Attachment 301544 [details] pushed as 8769b3d - input-settings: Ensure that we always apply the same set of settings