After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747393 - cerbero: Properly specify aclocal system directories
cerbero: Properly specify aclocal system directories
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
unspecified
Other All
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 747713 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-04-06 07:14 UTC by Edward Hervey
Modified: 2015-04-12 11:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
cerbero: Properly specify aclocal system directories (1.81 KB, patch)
2015-04-06 07:14 UTC, Edward Hervey
rejected Details | Review
cerbero: Properly specify aclocal search directories (2.18 KB, patch)
2015-04-06 07:48 UTC, Edward Hervey
none Details | Review
cerbero: Properly specify aclocal search directories (2.26 KB, patch)
2015-04-06 07:51 UTC, Edward Hervey
committed Details | Review

Description Edward Hervey 2015-04-06 07:14:01 UTC
Currently the cerbero dist/build "system" m4 directories are specified with
-I arguments to aclocal

The problem with that is that aclocal will search for m4 in that order (first
system directories, then local ones), whereas the logic should be the opposite
(it first looks for m4 in local directories and *then* look in the 'system' ones)

The patches fixes that by using the proper aclocal arguments --system-acdir
Comment 1 Edward Hervey 2015-04-06 07:14:08 UTC
Created attachment 300999 [details] [review]
cerbero: Properly specify aclocal system directories

aclocal needs to know the difference between local and system m4 directories
otherwise it will pick up the m4 in the wrong order (it should first pick from
the specified local m4 directories and *then* if not present check in the
system directories).
Comment 2 Edward Hervey 2015-04-06 07:48:51 UTC
Created attachment 301001 [details] [review]
cerbero: Properly specify aclocal search directories

aclocal needs to know the difference between local and system m4 directories
otherwise it will pick up the m4 in the wrong order (it should first pick from
the specified local m4 directories and *then* if not present check in the
system directories).

We don't need to specify the build ac directory since aclocal already knows
that.

What we *do* need to specify is our local 'dist' ac directory containing the m4
of previously compiled packages, and that should be done solely by setting
the proper ACLOCAL_FLAGS.

If a package fails after this commit, check that ACLOCAL_FLAGS gets properly
set as the *last* argument of aclocal.
Comment 3 Edward Hervey 2015-04-06 07:51:09 UTC
Created attachment 301002 [details] [review]
cerbero: Properly specify aclocal search directories

aclocal needs to know the difference between local and system m4 directories
otherwise it will pick up the m4 in the wrong order (it should first pick from
the specified local m4 directories and *then* if not present check in the
system directories).

We don't need to specify the build ac directory since aclocal already knows
that.

What we *do* need to specify is our local 'dist' ac directory containing the m4
of previously compiled packages, and that should be done solely by setting
the proper ACLOCAL_FLAGS.

If a package fails after this commit, check that ACLOCAL_FLAGS gets properly
set as the *last* argument of aclocal.

Tip: You can check the include order by looking at autom4te.cache/requests
Comment 4 Edward Hervey 2015-04-06 08:10:37 UTC
commit 7b107bea8db7767e105ca895771c9bf7915255c7
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Mon Apr 6 09:04:45 2015 +0200

    cerbero: Properly specify aclocal search directories
    
    aclocal needs to know the difference between local and system m4 directories
    otherwise it will pick up the m4 in the wrong order (it should first pick from
    the specified local m4 directories and *then* if not present check in the
    system directories).
    
    We don't need to specify the build ac directory since aclocal already knows
    that.
    
    What we *do* need to specify is our local 'dist' ac directory containing the m4
    of previously compiled packages, and that should be done solely by setting
    the proper ACLOCAL_FLAGS.
    
    If a package fails after this commit, check that ACLOCAL_FLAGS gets properly
    set as the *last* argument of aclocal.
    
    Tip: You can check the include order by looking at autom4te.cache/requests
    
    https://bugzilla.gnome.org/show_bug.cgi?id=747393
Comment 5 Sebastian Dröge (slomo) 2015-04-12 11:28:50 UTC
*** Bug 747713 has been marked as a duplicate of this bug. ***