GNOME Bugzilla – Bug 747283
configure: playback and seek tests build error with gtk < 3.10.0
Last modified: 2015-04-03 14:43:31 UTC
There's a build error in gst-plugins-base/tests/examples/ like below playback-test.c: In function ‘create_ui’: playback-test.c:2640:3: error: implicit declaration of function ‘gtk_button_new_from_icon_name’ [-Werror=implicit-function-declaration] playback-test.c:2640:3: error: nested extern declaration of ‘gtk_button_new_from_icon_name’ [-Werror=nested-externs] playback-test.c:2640:15: error: assignment makes pointer from integer without a cast [-Werror] playback-test.c:2642:16: error: assignment makes pointer from integer without a cast [-Werror] playback-test.c:2644:15: error: assignment makes pointer from integer without a cast [-Werror] playback-test.c:2833:17: error: assignment makes pointer from integer without a cast [-Werror] playback-test.c:3194:17: error: assignment makes pointer from integer without a cast [-Werror] CCLD gtk-videooverlay cc1: all warnings being treated as errors CCLD audiomix make[4]: *** [playback-test.o] Error 1 make[4]: Leaving directory `/home/chihyoung/opensrc/jhbuild-gstreamer/build/gst-plugins-base/tests/examples/playback' make[3]: *** [playback] Error 2 make[3]: *** Waiting for unfinished jobs.... CC jsseek.o CC sprinkle3-sprinkle3.o CCLD volume make[4]: Leaving directory `/home/chihyoung/opensrc/jhbuild-gstreamer/build/gst-plugins-base/tests/examples/fft' CCLD stepping CC appsrc_ra-appsrc-ra.o CCLD stepping2 make[4]: Leaving directory `/home/chihyoung/opensrc/jhbuild-gstreamer/build/gst-plugins-base/tests/examples/encoding' CC appsrc_seekable-appsrc-seekable.o CCLD addstream CCLD appsink-src CCLD appsink-src2 make[4]: Leaving directory `/home/chihyoung/opensrc/jhbuild-gstreamer/build/gst-plugins-base/tests/examples/audio' CCLD sprinkle make[4]: Leaving directory `/home/chihyoung/opensrc/jhbuild-gstreamer/build/gst-plugins-base/tests/examples/overlay' CCLD sprinkle2 CCLD scrubby CCLD sprinkle3 CCLD appsrc_ex CCLD appsrc-stream jsseek.c: In function ‘main’: jsseek.c:2737:3: error: implicit declaration of function ‘gtk_button_new_from_icon_name’ [-Werror=implicit-function-declaration] jsseek.c:2737:3: error: nested extern declaration of ‘gtk_button_new_from_icon_name’ [-Werror=nested-externs] jsseek.c:2737:15: error: assignment makes pointer from integer without a cast [-Werror] jsseek.c:2739:16: error: assignment makes pointer from integer without a cast [-Werror] jsseek.c:2741:15: error: assignment makes pointer from integer without a cast [-Werror] jsseek.c:2800:17: error: assignment makes pointer from integer without a cast [-Werror] jsseek.c:2911:17: error: assignment makes pointer from integer without a cast [-Werror] cc1: all warnings being treated as errors CCLD appsrc-stream2 make[4]: *** [jsseek.o] Error 1 The function "gtk_button_new_from_icon_name" is available from GTK+-3.10 But my gtk version is GTK+-3.0.0, so this build error occurs.
Created attachment 300867 [details] [review] configure: fix build error in playback and seek tests This patch is for fixing build error in tests. The "gtk_button_new_from_icon_name" function was added in before patch. But this function is available from GTK+-3.10. there's a build error under GTK+-3.10. So, i update 'GTK_REQ' from 3.0.0 to 3.10. Thank you.
Thanks, pushed: commit cca103296d3e1c2754f1b629754c93c1dd9035c9 Author: Chihyoung Kim <chihyoung2.kim@lge.com> Date: Fri Apr 3 13:56:28 2015 +0900 tests: require Gtk+ 3.10 for examples Fixes build of playback and seek tests when an older Gtk+ version is present on the system. https://bugzilla.gnome.org/show_bug.cgi?id=747283
Isn't this situation slightly caused by recent deprecation fixes ? Also a side note, not a big deal to me, but GTK 3.10 requires GLib 2.37, while we claim to support 2.32.
Probably yes. I don't see a problem with requiring a more recent Gtk 3.10, this is just for some silly test programs.
Agreed.
Nicolas, yes it is. This problem is caused by 0ac3ad0abb714c77a2005a00f23ca2c959320146 and fc74875edc530f7ec94d32a26ec93aab4ab89ea5