GNOME Bugzilla – Bug 746747
rtpsession: Also report internal sources in on-new-ssrc and on-ssrc-active
Last modified: 2015-10-02 13:41:29 UTC
See commit message :)
Created attachment 300280 [details] [review] rtpsession: Also report internal sources in on-new-ssrc and on-ssrc-active Without this it seems impossible for an application to easily get notified about the internal ssrcs that are created, e.g. sender sources, and also to know when they are active and produce RTCP packets.
The use case here is to get the sender ssrc, and then whenever on-ssrc-active is emitted get the rtp stats from the source that corresponds to that ssrc. I don't see how this is easily possible otherwise currently. Distinguishing sender from non-sender ssrcs can be done by checking the "is-sender" property on the source if that is necessary for something.
commit d22ec496328e6ba8edbf2d071d5608b2af2831e8 Author: Sebastian Dröge <sebastian@centricular.com> Date: Wed Mar 25 15:27:34 2015 +0100 rtpsession: Also report internal sources in on-new-ssrc and on-ssrc-active Without this it seems impossible for an application to easily get notified about the internal ssrcs that are created, e.g. sender sources, and also to know when they are active and produce RTCP packets. https://bugzilla.gnome.org/show_bug.cgi?id=746747
commit 27729a2960763411362623d71ee05b734f325305 Author: Sebastian Dröge <sebastian@centricular.com> Date: Thu May 7 14:51:45 2015 +0200 Revert "rtpsession: Also report internal sources in on-new-ssrc and on-ssrc-active" This reverts commit d22ec496328e6ba8edbf2d071d5608b2af2831e8. Application code might expect that it only gets external sources on those signals, and get confused by this. If anything we would need to add new signals.
*** Bug 753787 has been marked as a duplicate of this bug. ***
Sebastian, so, we can add new signal for this? One more question, It's same reason for why PROP_INTERNAL_SSRC and PROP_INTERNAL_SOURCE ared deprecated?
We could add a "on-new-sender-ssrc" and "on-sender-ssrc-active" ?
Yeah, sounds like the best approach
Created attachment 309668 [details] [review] rtpmanager: add new on-new-sender-ssrc, on-sender-ssrc-active signals
Created attachment 309669 [details] [review] stream: listen to sender ssrc signals Listen new signals in gst-rtsp-server
Comment on attachment 309668 [details] [review] rtpmanager: add new on-new-sender-ssrc, on-sender-ssrc-active signals Looks good but please update the Since markers to 1.8
Created attachment 309677 [details] [review] rtpmanager: add new on-new-sender-ssrc, on-sender-ssrc-active signals Changes marker to 1.8
Created attachment 312546 [details] [review] rtpmanager: add new on-new-sender-ssrc, on-sender-ssrc-active signals Rebased on the latest master
Created attachment 312547 [details] [review] stream: listen to sender ssrc signals Rebased on the latest master
commit 2b1f52755df222d56f1e9c4a52826539e8f9c062 Author: Hyunjun Ko <zzoon.ko@samsung.com> Date: Fri Oct 2 16:16:32 2015 +0900 rtpmanager: add new on-new-sender-ssrc, on-sender-ssrc-active signals Allows for applications to get internal source's RTP statistics. (eg. sender sources for a server/client) https://bugzilla.gnome.org/show_bug.cgi?id=746747 commit a51337974cdb1aa56db5e4ef87a1bb52a7423979 Author: Hyunjun Ko <zzoon.ko@samsung.com> Date: Fri Oct 2 16:11:05 2015 +0900 stream: listen to sender ssrc signals https://bugzilla.gnome.org/show_bug.cgi?id=746747