After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746622 - [PATCH] Update the CMake builtin command and variable lists
[PATCH] Update the CMake builtin command and variable lists
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
git master
Other All
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-22 22:36 UTC by Роман Донченко
Modified: 2015-04-13 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch 1 (6.59 KB, patch)
2015-03-22 22:36 UTC, Роман Донченко 		none Details | Review
Patch 2 (21.44 KB, patch)
2015-03-22 22:37 UTC, Роман Донченко 		committed Details | Review
Patch 1 (v2) (4.67 KB, patch)
2015-03-24 21:49 UTC, Роман Донченко 		committed Details | Review
Patch 3 (4.27 KB, patch)
2015-03-24 21:50 UTC, Роман Донченко 		committed Details | Review

Description Роман Донченко 2015-03-22 22:36:24 UTC 
Attaching two patches. See the commit messages for details.
Comment 1 Роман Донченко 2015-03-22 22:36:59 UTC 
Created attachment 300095 [details] [review]
Patch 1
Comment 2 Роман Донченко 2015-03-22 22:37:29 UTC 
Created attachment 300096 [details] [review]
Patch 2
Comment 3 Paolo Borelli 2015-03-23 10:39:27 UTC 
Can patch 2 be applied without patch 1?

The first patch adds a translated string so it will need to go in after we branch.
Comment 4 Роман Донченко 2015-03-23 17:44:50 UTC 
Yes, absolutely. I can also split off the part of patch 1 that adds the string into a separate patch, so that the bulk of patch 1 could be applied earlier, if you want.
Comment 5 Paolo Borelli 2015-03-23 17:48:32 UTC 
that would be great
Comment 6 Роман Донченко 2015-03-24 21:49:40 UTC 
Created attachment 300229 [details] [review]
Patch 1 (v2)
Comment 7 Роман Донченко 2015-03-24 21:50:25 UTC 
Created attachment 300230 [details] [review]
Patch 3
Comment 8 Paolo Borelli 2015-03-25 10:49:45 UTC 
Ok, I applied 1 & 2.

I'll keep this open and apply 3 once we branch. Thanks!
Comment 9 Sébastien Wilmet 2015-04-13 16:48:51 UTC 
Comment on attachment 300230 [details] [review]
Patch 3

Commit pushed.