GNOME Bugzilla – Bug 746574
matroskamux: add G722 audio support
Last modified: 2016-12-20 10:49:46 UTC
Created attachment 300024 [details] [review] G722 support add G722 support to matroskamux, tested this way: gst-launch-1.0 -ve pulsesrc ! audioconvert ! audioresample ! avenc_g722 ! matroskamux ! filesink location=/tmp/test.mkv the resulting file can be played by vlc/ffmpeg and gstreamer ffmpeg -f alsa -ar 8000 -i "hw:1,0" -acodec g722 -ac 1 -ar 16000 /tmp/test1.mkv the resulting file can be played by gstreamer
Created attachment 300025 [details] [review] fix riff for G722 riff codec id as ffmpeg
Comment on attachment 300025 [details] [review] fix riff for G722 Thanks for the patch. Some quick googling suggests that both 0x65 and 0x028f are in use for G.722 audio and mean the same, so I'm wondering if we shouldn't at least keep the 0x65 mapping around for reading. (e.g. google for 'VS1063a Datasheet G.722')
ok we can keep: #define GST_RIFF_WAVE_FORMAT_G722_ADPCM (0x0065) and add: #define GST_RIFF_WAVE_FORMAT_ADPCM_G722 (0x028F) and use the last one for matroskamux, what do you think about? 0x028F is used by ffmpeg/libav/vlc/mplayer (pratically all the players I tested)
Yes, that sounds good. Thanks.
Created attachment 300519 [details] [review] G722 support in matroskamux
Created attachment 300520 [details] [review] add ADPCM_G722 support
ping
any news on this patch?
Comment on attachment 300520 [details] [review] add ADPCM_G722 support commit a75be734718fc45f5ffe2e71209bdd37c65edde2 Author: Nicola Murino <nicola.murino@gmail.com> Date: Sat Mar 28 18:16:16 2015 +0100 riff: add ADPCM_G722 support https://bugzilla.gnome.org/show_bug.cgi?id=746574
commit 92626d4085b97405aa73e5b56d312e493595356f Author: Nicola Murino <nicola.murino@gmail.com> Date: Sat Mar 28 18:15:36 2015 +0100 matroskamux: add G722 audio support https://bugzilla.gnome.org/show_bug.cgi?id=746574