After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746545 - wayland: try 50 times to create lock file again for login screen
wayland: try 50 times to create lock file again for login screen
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-20 19:13 UTC by Ray Strode [halfline]
Modified: 2015-04-01 14:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wayland: try 50 times to create lock file again for login screen (2.45 KB, patch)
2015-03-20 19:13 UTC, Ray Strode [halfline]
none Details | Review

Description Ray Strode [halfline] 2015-03-20 19:13:04 UTC
since commit 8c16ac47c1b88fc48ad8ea621a75a86e028a2764, we started
creating the login screen on display 1024 instead of display 0.

This defeats this logic in try_display:

    display++;
    /* If display is above 50, then something's wrong. Just
     * abort in this case. */
    if (display > 50)

In practice it doesn't matter much since we only have one login
screen in most setups, but we should still fix the bug.

This commit introduces a separate counter to keep try of 50 tries,
rather than assuming "display number == number of tries".
Comment 1 Ray Strode [halfline] 2015-03-20 19:13:07 UTC
Created attachment 299982 [details] [review]
wayland: try 50 times to create lock file again for login screen
Comment 2 Ray Strode [halfline] 2015-04-01 14:31:21 UTC
Attachment 299982 [details] pushed as a5d1f67 - wayland: try 50 times to create lock file again for login screen