Bug 746425 – Gnome-terminal theme is broken since commit be596f39

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 746425 - Gnome-terminal theme is broken since commit be596f39


Summary:	Gnome-terminal theme is broken since commit be596f39


Status:	RESOLVED FIXED

Product:	gnome-terminal
Classification:	Core
Component:	general
Version:	3.15.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	GNOME Terminal Maintainers
QA Contact:	GNOME Terminal Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2015-03-19 00:07 UTC by Vadim Rutkovsky
Modified:	2015-03-24 07:41 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
screen: Update colors at the right spot (2.82 KB, patch) 2015-03-20 22:09 UTC, Benjamin Otte (Company)	committed	Details \| Review
screen: When getting system colors, use the right state (1.28 KB, patch) 2015-03-20 22:09 UTC, Benjamin Otte (Company)	committed	Details \| Review

Description Vadim Rutkovsky 2015-03-19 00:07:21 UTC

Since http://build.gnome.org/#/build/20150318.55 gnome-terminal background has been rendered black: http://build.gnome.org/continuous/buildmaster/builds/2015/03/18/55/applicationstest/work-gnome-continuous-x86_64-runtime/screenshot-gnome-terminal.desktop.png, while it should be white: http://build.gnome.org/continuous/buildmaster/builds/2015/03/18/53/applicationstest/work-gnome-continuous-x86_64-runtime/screenshot-gnome-terminal.desktop.png

Comment 1 Jakub Steiner 2015-03-20 10:17:15 UTC

All the commits to theming/css on the 17th have been made for HighContrast and not for Adwaita. The closes commit touching gtk.css is 6f478db2facd8744714b7ab374d2687d777653a3

Comment 2 Benjamin Otte (Company) 2015-03-20 22:09:14 UTC

Created attachment 300002 [details] [review]
screen: Update colors at the right spot

The window is not the right place to listen for style changes on the
TerminalScreen widget.

Comment 3 Benjamin Otte (Company) 2015-03-20 22:09:45 UTC

Created attachment 300003 [details] [review]
screen: When getting system colors, use the right state

This is relevant because text direction is part of the state these days
so it will never be STATE_FLAG_NORMAL.

Comment 4 Benjamin Otte (Company) 2015-03-20 22:13:22 UTC

This is fallout from me merging the CSS engine rework in master. (Seems we got better at not emitting style-updated on the window, yay!)

Comment 5 Matthias Clasen 2015-03-22 04:01:56 UTC

moving this to gnome-terminal, then

Comment 6 Christian Persch 2015-03-22 20:04:24 UTC

Thanks! Please commit after the freeze ends.