After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746376 - Move counter in subtitle does not update when playing with keyboard
Move counter in subtitle does not update when playing with keyboard
Status: RESOLVED FIXED
Product: lightsoff
Classification: Applications
Component: general
3.15.x
Other Linux
: Normal minor
: ---
Assigned To: lightsoff-maint
lightsoff-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-17 23:55 UTC by Michael Catanzaro
Modified: 2015-03-28 20:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update moves' counter on keyboard move. (1.44 KB, patch)
2015-03-18 04:13 UTC, Arnaud B. 		committed Details | Review

Description Michael Catanzaro 2015-03-17 23:55:23 UTC 
Arnaud discovered that the move counter in the header bar subtitle is only updated when toggling lights with the mouse, not when using the keyboard (arrow keys to move, Enter to toggle).
Comment 1 Arnaud B. 2015-03-18 04:13:43 UTC 
Created attachment 299679 [details] [review]
Update moves' counter on keyboard move.

This patch is enough to make that work. I think we should ask for a freeze break, do you agree?
Comment 2 Robert Roth 2015-03-22 06:50:07 UTC 
Yes, this would require a freeze break indeed, but I wonder if it's not too late for that (release being tomorrow). In any case, the code looks safe enough, and will surely get into 3.16.1.
If you want, you could still ask for a freeze exception, I agree with that.
Comment 3 Arnaud B. 2015-03-22 09:23:45 UTC 
Looks like I’m stuck with a Wayland session (why GDM, why??), so I cannot test again my patch, and as I have other things to do than to correct that, I won’t request for a freeze break. For 3.16.1.
Comment 4 Michael Catanzaro 2015-03-28 16:45:53 UTC 
Arnaud, Robert, time to push this?
Comment 5 Robert Roth 2015-03-28 20:32:11 UTC 
Attachment 299679 [details] pushed as a1760ed - Update moves' counter on keyboard move.