Created attachment 299628 [details] [review]
TelepathyClient: fix ackowledging chat messages

ChatSource relies on the 'expanded' signal on the banner to
ack messages, but no code ever emits that.

Created attachment 299629 [details] [review]
Telepathy: hide chat notifications when focusing the app

When the chat app is focused, we should hide all banners immediately.
A good way to do so, without tracking which app is focused, is
to look for messages that are acked when the banner is unexpanded,
which implies they were acked by some other telepathy client.

Review of attachment 299628 [details] [review]:

LG. (Would need a freeze break exception though).

Review of attachment 299629 [details] [review]:

Make sense didn't test it though (comment re freeze break applies here too).

Review of attachment 299628 [details] [review]:

::: js/ui/calendar.js
@@ +1111,3 @@
     },
 
     unexpand: function(animate) {

Also for symmetry, please add an 'unexpanded' signal (even though unused)

Should we ask for a freeze break or wait for 3.16.1? It's not a crasher or high priority

Up to you, but I think waiting for 3.16.1 is not too big of an issue (not least because we do end up acknowledging messages in cases of follow-ups[0]) ...

[0] https://git.gnome.org/browse/gnome-shell/tree/js/ui/components/telepathyClient.js#n279

Attachment 299628 [details] pushed as 934ec3c - TelepathyClient: fix ackowledging chat messages
Attachment 299629 [details] pushed as d8926b9 - Telepathy: hide chat notifications when focusing the app