After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746359 - client: let DISPLAY flow through
client: let DISPLAY flow through
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-17 19:46 UTC by Ray Strode [halfline]
Modified: 2015-03-18 11:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
client: let DISPLAY flow through (3.46 KB, patch)
2015-03-17 19:46 UTC, Ray Strode [halfline] 		accepted-commit_after_freeze Details | Review

Description Ray Strode [halfline] 2015-03-17 19:46:08 UTC 
gnome-terminal currently unsets DISPLAY before forking its child,
and then recreates it from gdk_display_get_name when constructing
the child environment.

This is fine for the X11 backend, but poses a problem for wayland.
wayland clients don't need DISPLAY set, but X clients using Xwayland
do. The code to reconstruct DISPLAY when constructing the child
environment isn't run for the wayland backend (and wouldn't work
on the wayland backend anyway).

This commit keeps DISPLAY set, so X clients started from gnome-terminal
work when using the wayland backend.
Comment 1 Ray Strode [halfline] 2015-03-17 19:46:26 UTC 
Created attachment 299622 [details] [review]
client: let DISPLAY flow through
Comment 2 Christian Persch 2015-03-17 20:26:14 UTC 
Comment on attachment 299622 [details] [review]
client: let DISPLAY flow through

Thanks! Up to you if you want to wait till after 3.16.0, or ask r-t for approval to commit immediately.
Comment 3 Ray Strode [halfline] 2015-03-18 11:51:53 UTC 
got rt approval.

Attachment 299622 [details] pushed as ad4ed0a - client: let DISPLAY flow through