After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746323 - The legacyTray should stay below the modalDialogGroup
The legacyTray should stay below the modalDialogGroup
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.15.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-17 01:45 UTC by Michele
Modified: 2015-03-23 19:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
legacyTray: Stack tray below modal dialogs (1.14 KB, patch)
2015-03-19 11:49 UTC, Florian Müllner
committed Details | Review

Description Michele 2015-03-17 01:45:02 UTC
I don't see any reason why it shouldn't as any other ui element.
Comment 1 Isaac Ge 2015-03-17 10:54:33 UTC
Sorry, I find that legacyTray and modalDialogGroup are two js file in the source, but I do not understand what do you mean.
Comment 2 Michele 2015-03-17 13:55:24 UTC
If you enter a modal state - such as the select wifi network of the the logout panel - you will see that you can still interact with the legacytray, which is again the modal way. All other elements get covered by a gray actor and the interaction with them is blocked.

My understanding is that what is stacked below the modalDialogGroup is blocked, what's above is not, but there might be another way to achieve the desired behaviour.
Comment 3 Isaac Ge 2015-03-18 06:18:35 UTC
OK, I understand what is a modal state now, but what is legacytray?

If it is that bar in the picture[1]. I do not unserstand how to interact with it in a modal state, I have tried. You should describe how to reproduce it, thank you!

[1]: http://img.vim-cn.com/08/50b4164f6f6aeb382d1582c0d128b20cfc3896.png
Comment 4 Jasper St. Pierre (not reading bugmail) 2015-03-18 06:36:46 UTC
That's the message tray and has been removed in 3.16. The "legacy tray" is where status icons are now.

http://fedoramagazine.org/wp-content/uploads/2015/03/new-notifications-system-tray.png.jpg
Comment 5 Isaac Ge 2015-03-18 12:54:46 UTC
Well... I understand it finally now, as what Michele said, I can interact with the legacy tray in a modal state ion 3.15.92.

So what do gnome-shell developer think? Should I fix this "bug"?
Comment 6 Florian Müllner 2015-03-18 13:33:56 UTC
Sure - the current behavior is clearly not intentional and doesn't make sense.
Comment 7 Isaac Ge 2015-03-19 05:55:15 UTC
(In reply to Florian Müllner from comment #6)
> Sure - the current behavior is clearly not intentional and doesn't make sense.

I have read the code a lot time... and still do not know how to fix it. Could you give any tips please?
Comment 8 Florian Müllner 2015-03-19 11:49:59 UTC
Created attachment 299801 [details] [review]
legacyTray: Stack tray below modal dialogs

System modal dialogs should disable other UI while open, so make
sure the legacy tray does not appear on top of them.


(In reply to Isaac Ge from comment #7)
> Could you give any tips please?

Considering it's a one-liner - not really without writing the actual patch :-)
Comment 9 Jasper St. Pierre (not reading bugmail) 2015-03-19 15:01:02 UTC
Review of attachment 299801 [details] [review]:

OK. I would much prefer an explicit legacyTrayBox in layout.js, but this is fine too.
Comment 10 Isaac Ge 2015-03-23 05:02:41 UTC
(In reply to Florian Müllner from comment #8)

> Considering it's a one-liner - not really without writing the actual patch
> :-)

So the problem is solved and I have nothing to do now?
Comment 11 Florian Müllner 2015-03-23 19:21:23 UTC
Attachment 299801 [details] pushed as 2ce7a3b - legacyTray: Stack tray below modal dialogs