GNOME Bugzilla – Bug 746194
Ambiguous references between GLib.ListStore and Gtk.ListStore
Last modified: 2015-04-19 21:11:30 UTC
Glib now has a new class Glib.ListStore, which creates a conflict in Vala.
Created attachment 299379 [details] [review] Fix for ambiguous references
Review of attachment 299379 [details] [review]: Looks good to me. I've set the patch to "commit now" if you can't commit and need access, we can get that set up for you. IF you're working on the code base for any period, it will make more sense! Thanks for the patch :)
Thanks for review. Yes, according to the plans it will make more sense. I don't have access. Please get that set up for me.
(In reply to Kunaal Jain from comment #3) > Thanks for review. > Yes, according to the plans it will make more sense. I don't have access. > Please get that set up for me. Please see: https://wiki.gnome.org/AccountsTeam/NewAccounts
The Pre-requisites specifically say "We do request that applicants have submitted a reasonable number of patches to an existing maintainer, or bugzilla reports before they request direct commit access". I am not sure if I qualify for that.
Well "reasonable" is really not a measurable number :) And since we know what you'll be doing and have already done, I think it will be fine. They ask for our permission too normally - you don't just get it ;)
Created attachment 300142 [details] [review] tracker-needle: Fix for ambiguous references
Martyn, I have applied for the account. I am attaching another patch file. This fixes ambiguous references in tracker-needle. Without this on systems with updated glib and gtk, build for tracker-needle fails.
Review of attachment 300142 [details] [review]: Thanks for the patch! :)
Review of attachment 299379 [details] [review]: Thanks ;)