After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746194 - Ambiguous references between GLib.ListStore and Gtk.ListStore
Ambiguous references between GLib.ListStore and Gtk.ListStore
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Preferences
git master
Other Linux
: Normal major
: ---
Assigned To: tracker-preferences
tracker-preferences
Depends on:
Blocks:
 
 
Reported: 2015-03-14 05:20 UTC by Kunaal Jain
Modified: 2015-04-19 21:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix for ambiguous references (5.10 KB, patch)
2015-03-14 05:24 UTC, Kunaal Jain
committed Details | Review
tracker-needle: Fix for ambiguous references (2.10 KB, patch)
2015-03-23 15:40 UTC, Kunaal Jain
committed Details | Review

Description Kunaal Jain 2015-03-14 05:20:19 UTC
Glib now has a new class Glib.ListStore, which creates a conflict in Vala.
Comment 1 Kunaal Jain 2015-03-14 05:24:25 UTC
Created attachment 299379 [details] [review]
Fix for ambiguous references
Comment 2 Martyn Russell 2015-03-17 19:24:22 UTC
Review of attachment 299379 [details] [review]:

Looks good to me. I've set the patch to "commit now" if you can't commit and need access, we can get that set up for you. IF you're working on the code base for any period, it will make more sense!
Thanks for the patch :)
Comment 3 Kunaal Jain 2015-03-18 10:43:33 UTC
Thanks for review.
Yes, according to the plans it will make more sense. I don't have access. Please get that set up for me.
Comment 4 Martyn Russell 2015-03-20 19:56:30 UTC
(In reply to Kunaal Jain from comment #3)
> Thanks for review.
> Yes, according to the plans it will make more sense. I don't have access.
> Please get that set up for me.

Please see:
  https://wiki.gnome.org/AccountsTeam/NewAccounts
Comment 5 Kunaal Jain 2015-03-20 20:20:21 UTC
The Pre-requisites specifically say "We do request that applicants have submitted a reasonable number of patches to an existing maintainer, or bugzilla reports before they request direct commit access". I am not sure if I qualify for that.
Comment 6 Martyn Russell 2015-03-20 20:37:20 UTC
Well "reasonable" is really not a measurable number :)
And since we know what you'll be doing and have already done, I think it will be fine.

They ask for our permission too normally - you don't just get it ;)
Comment 7 Kunaal Jain 2015-03-23 15:40:48 UTC
Created attachment 300142 [details] [review]
tracker-needle: Fix for ambiguous references
Comment 8 Kunaal Jain 2015-03-23 15:41:10 UTC
Martyn, I have applied for the account. 

I am attaching another patch file. This fixes ambiguous references in tracker-needle. Without this on systems with updated glib and gtk, build for tracker-needle fails.
Comment 9 Martyn Russell 2015-03-23 22:27:47 UTC
Review of attachment 300142 [details] [review]:

Thanks for the patch! :)
Comment 10 Martyn Russell 2015-03-23 22:35:11 UTC
Review of attachment 299379 [details] [review]:

Thanks ;)