GNOME Bugzilla – Bug 746125
Redundant "No conversations selected" in right headerbar
Last modified: 2015-03-13 19:39:01 UTC
I'm seeing two issues with Geary in current master: * Sometimes I'm not seeing "No conversations selected" in the conversation viewer when no conversation is selected. The label on the top headerbar shows the message. I don't know how to reproduce this state. It seems like they're both shown when the app is first executed but some time after I don't see the message in the conversation viewer. * I'm now unsure if we want "No conversations selected" in both locations anyway -- it feels redundant. I think we should pick one and stick to it. I lean toward the conversation viewer and leaving the top headerbar blank in that situation, as it helps keep the conversation viewer from looking like a big blank field.
I think point one is bug 744066. As I note there, we may be able to solve it with some CSS trickery. Point two is easy. The header bar title code is actually completely separate.
> I think point one is bug 744066. Ah, ok. I've changed the title of this ticket to reflect the second point only. I'm targeting this for 0.10, since we think it'll be straightforward.
Created attachment 299355 [details] [review] Don't set conversation title for zero or multiple conversations I've also removed the title when there are multiple conversations. But we can easily keep one and not the other if you prefer.
Review of attachment 299355 [details] [review]: No, that's perfect. Commit!
Attachment 299355 [details] pushed as 1d0e58b - Don't set conversation title for zero or multiple conversations