After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746098 - monitor-manager-kms: Tell cogl to ignore CRTCs when DPMS isn't ON
monitor-manager-kms: Tell cogl to ignore CRTCs when DPMS isn't ON
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-12 16:16 UTC by Rui Matos
Modified: 2015-03-16 15:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
monitor-manager-kms: Tell cogl to ignore CRTCs when DPMS isn't ON (1.58 KB, patch)
2015-03-12 16:16 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2015-03-12 16:16:55 UTC 
Otherwise cogl will try to page flip and fail.
Comment 1 Rui Matos 2015-03-12 16:16:59 UTC 
Created attachment 299216 [details] [review]
monitor-manager-kms: Tell cogl to ignore CRTCs when DPMS isn't ON
Comment 2 drago01 2015-03-12 17:05:29 UTC 
Review of attachment 299216 [details] [review]:

Makes sense.
Comment 3 drago01 2015-03-12 17:06:44 UTC 
Review of attachment 299216 [details] [review]:

Err no ... got this backwards.

Don't you want to ignore crtcs when DPMS is *on* ?
Comment 4 Rui Matos 2015-03-12 17:28:30 UTC 
(In reply to drago01 from comment #3)
> Don't you want to ignore crtcs when DPMS is *on* ?

META_POWER_SAVE_ON aka DRM_MODE_DPMS_ON is the state where we're actually showing something so what we want is tell cogl to ignore (not flip) for any other values of that enum.

Yes, there are several levels of negation going on with the enums and API...
Comment 5 drago01 2015-03-16 15:29:44 UTC 
(In reply to Rui Matos from comment #4)
> (In reply to drago01 from comment #3)
> > Don't you want to ignore crtcs when DPMS is *on* ?
> 
> META_POWER_SAVE_ON aka DRM_MODE_DPMS_ON is the state where we're actually
> showing something so what we want is tell cogl to ignore (not flip) for any
> other values of that enum.
> 
> Yes, there are several levels of negation going on with the enums and API...

Yeah got confused by that. Looks good then.
Comment 6 Rui Matos 2015-03-16 15:40:02 UTC 
Attachment 299216 [details] pushed as 43058a3 - monitor-manager-kms: Tell cogl to ignore CRTCs when DPMS isn't ON