After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746097 - nmcli: allow specifying multiple interfaces for nmcli device disconnect and delete
nmcli: allow specifying multiple interfaces for nmcli device disconnect and d...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nmcli
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-03-12 14:49 UTC by Jiri Klimes
Modified: 2015-03-20 10:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jiri Klimes 2015-03-12 14:49:45 UTC 
It would provide much better user experience. There is no reason why this should not be supported.
Comment 1 Jiri Klimes 2015-03-12 14:54:39 UTC 
Implemented and pushed to branch jk/nmcli-dev-multiple-args-bgo746097.
Comment 2 Thomas Haller 2015-03-12 15:53:15 UTC 
(TODO: bash completion)
Comment 3 Jiri Klimes 2015-03-13 10:07:40 UTC 
Bash completion updated, branch re-pushed.
Comment 4 Dan Williams 2015-03-19 21:44:26 UTC 
Hmm, in device_cb_info_finish() could the if (device) case also just call destroy_queue_element() to replace the:

+		g_signal_handlers_disconnect_by_func (device, disconnect_state_cb, info);
+		g_object_unref (device);

or is the 'info' data there important?

The rest looks OK to me.
Comment 5 Jiri Klimes 2015-03-20 10:13:48 UTC 
(In reply to Dan Williams from comment #4)
> Hmm, in device_cb_info_finish() could the if (device) case also just call
> destroy_queue_element() to replace the:
> 
> +		g_signal_handlers_disconnect_by_func (device, disconnect_state_cb, info);
> +		g_object_unref (device);
> 
> or is the 'info' data there important?

Yes, it could. info was important just for g_signal_handlers_disconnect_by_func(), but not needed for g_signal_handlers_disconnect_matched(). I have changed the code as you suggested.

Pushed to master as:
b8a2f42 cli: allow multiple devices for 'nmcli device disconnect/delete' (bgo #746097)