After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746056 - gtk_source_buffer_join_lines() joins past end marker
gtk_source_buffer_join_lines() joins past end marker
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-11 22:48 UTC by Christian Hergert
Modified: 2015-03-12 19:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Christian Hergert 2015-03-11 22:48:56 UTC 
The join performed by gtk_source_buffer_join_lines() will move itself past the end iter until the next non-space char is selected.

By not stopping at the end iter, it prevents us from implementing vim style <shift>j correctly in Builder (which would swallow just the next line).
Comment 1 Paolo Borelli 2015-03-12 13:29:06 UTC 
Should be fixed, can you double check though?
Comment 2 Christian Hergert 2015-03-12 19:01:10 UTC 
It isn't inserting a space between the joined lines now.
Comment 3 Paolo Borelli 2015-03-12 19:51:52 UTC 
ooops, let's hope I got it right now.