After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746019 - Notifications don't show close button until there's motion
Notifications don't show close button until there's motion
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: calendar
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-11 09:46 UTC by Bastien Nocera
Modified: 2015-03-11 20:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
calendar: Sync pointer after a message is removed (1.53 KB, patch)
2015-03-11 18:14 UTC, Florian Müllner
committed Details | Review

Description Bastien Nocera 2015-03-11 09:46:28 UTC
When dismissing a notification through its close button in the calendar menu, the notification that slides into place doesn't show the hover state or the close button until we move the mouse.

(This also brings the question of how one dismisses notifications on a touchscreen).
Comment 1 Allan Day 2015-03-11 10:03:17 UTC
I was thinking that a slide gesture could be used to dismiss notifications on touch.
Comment 2 Florian Müllner 2015-03-11 13:00:33 UTC
(In reply to Allan Day from comment #1)
> I was thinking that a slide gesture could be used to dismiss notifications
> on touch.

See bug 745259 for that.
Comment 3 Florian Müllner 2015-03-11 18:14:41 UTC
Created attachment 299118 [details] [review]
calendar: Sync pointer after a message is removed

If a different message ends up underneath the pointer at the end
of the removal animation, it won't receive an enter event until
the pointer is moved, and thus its hover state will not be correct.
Fix it up manually with an explicit pointer sync.
Comment 4 Rui Matos 2015-03-11 19:48:05 UTC
Review of attachment 299118 [details] [review]:

Yeah, we get this wrong in many other places but I guess doing it generically would be too much overhead so. lgtm
Comment 5 Florian Müllner 2015-03-11 20:20:22 UTC
Attachment 299118 [details] pushed as bb73547 - calendar: Sync pointer after a message is removed