GNOME Bugzilla – Bug 745909
Classic mode - drop disclosure triangles and bold weight for menus
Last modified: 2015-03-11 14:04:18 UTC
Created attachment 298905 [details] screenshot, along with modified version Issues with the top "panel" in classic mode: * The places menu has a really small triangle, which is different in size from the others. * The label of the app menu isn't vertically aligned with the other text. * All the menu headers have disclosure triangles, except for time and date (and the workspace switcher in the bottom panel) - this is inconsistent. * The disclosure triangles makes the horizontal spacing look a bit awkward. * The text is bold everywhere. This isn't needed with dark text on a light background (and wasn't what GNOME 2 was like). Some suggestions: * Use regular rather than bold weight text. * Remove the disclosure triangles - they aren't needed in classic, since we assume that people are familiar with having menus in a grey bar along the top of the screen. * Remove the app icon from the app menu.
Created attachment 298910 [details] [review] theme: panel improvements - places menu still sports an arrow, must be a custom one
Created attachment 298914 [details] [review] Use a proper arrows instead of UTF8 All proper shell menus were updated to do that a while ago, we should do the same for consistency.
Review of attachment 298910 [details] [review]: ::: data/gnome-classic.scss @@ +40,3 @@ & > .system-status-icon { icon-shadow: none; } } + .app-menu-icon { width: 0; height: 0; display: none; margin: 0; } I'm not sure I like using "display: none" considering that we don't have any support for it at all ...
Created attachment 298968 [details] [review] theme: panel improvements - places menu still sports an arrow, must be a custom one
Review of attachment 298968 [details] [review]: LGTM ::: data/gnome-classic.scss @@ +40,3 @@ & > .system-status-icon { icon-shadow: none; } } + .app-menu-icon { width: 0; height: 0; margin: 0; } // shell's display:none; :D Oy! @@ +59,3 @@ +#appMenu { padding: 0 8px 0 8px; } +.popup-menu-arrow { width: 0; height: 0; } // shell's display: none; Missing smiley for consistency? :-p
Comment on attachment 298914 [details] [review] Use a proper arrows instead of UTF8 attachment 298914 [details] [review] pushed as 5e9f66f
Comment on attachment 298968 [details] [review] theme: panel improvements attachment 298968 [details] [review] pushed as 7cfd862
I don't think there's anything left here, please reopen if I overlooked anything.
Thanks for the fixes. Classic mode looks much better to me now.