After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745824 - Tray icon visible on the left screen if right is primary
Tray icon visible on the left screen if right is primary
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 746371 746477 746486 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-03-07 23:21 UTC by Bastien Nocera
Modified: 2015-03-22 08:35 UTC
See Also:
GNOME target: 3.16
GNOME version: ---

Attachments
floating status icons (310.81 KB, image/jpeg)
2015-03-07 23:21 UTC, Bastien Nocera 		  Details
gtk-embed: Handle unmap/map of the embedded window (3.09 KB, patch)
2015-03-20 01:39 UTC, Florian Müllner 		committed Details | Review

Description Bastien Nocera 2015-03-07 23:21:46 UTC 
Created attachment 298787 [details]
floating status icons

Legacy tray icons show "stashed" in a drawer on the bottom left of the primary screen. The problem is when there's a monitor visible on the left of the primary screen. It will show the status icons floating on the screen to the left of the primary screen.

See the attached screenshot.
Comment 1 Florian Müllner 2015-03-17 22:00:01 UTC 
*** Bug 746371 has been marked as a duplicate of this bug. ***
Comment 2 Florian Müllner 2015-03-19 18:48:00 UTC 
*** Bug 746477 has been marked as a duplicate of this bug. ***
Comment 3 Florian Müllner 2015-03-19 22:23:44 UTC 
*** Bug 746486 has been marked as a duplicate of this bug. ***
Comment 4 Florian Müllner 2015-03-20 01:39:15 UTC 
Created attachment 299900 [details] [review]
gtk-embed: Handle unmap/map of the embedded window

The current code assumes that an embedded window will correspond to
a single MetaWindow over the entire lifetime of the icon, which is
incorrect - the embedded window is unmanaged on Unmap and a new
MetaWindow will be created the next time the embedded window is
mapped. As we currently ignore the new MetaWindow completely, it
will be shown normally in the scene instead of the embedded clone
as intended.
Fix this by setting up clone and window actor each time the embedded
window is mapped rather than once in shell_gtk_embed_set_window().
Comment 5 William Shuman 2015-03-20 13:56:02 UTC 
Proposed patch fixes the issue for me. Thanks.
Comment 6 Rui Matos 2015-03-20 14:17:12 UTC 
Review of attachment 299900 [details] [review]:

This code is a maze. But, right, looks good. Probably worth a code freeze break given the number of bug reports
Comment 7 Florian Müllner 2015-03-22 08:35:15 UTC 
Freeze break request was approved, pushing.

Attachment 299900 [details] pushed as 169b00a - gtk-embed: Handle unmap/map of the embedded window