GNOME Bugzilla – Bug 745757
Improve the favorites emblem
Last modified: 2016-03-31 13:22:07 UTC
The favorites emblem is too big and uses a heart instead of a star. Also, the current thinking is to move it to the left corner to avoid competing with the selection check box (see bug 733311).
Sure, make sense. Its a UI change so can't push it into 3.16 anymore though.
Created attachment 305897 [details] [review] collection-view: Improve favorites emblem This moves the favorites emblem to the bottom left corner of the thumbnails and draws it as a small star instead of a big heart. This is needed to comply to GNOME's HIG and to make sure the favorites emblem don't conflict with item selection checkbox.
Review of attachment 305897 [details] [review]: Results looks really good but wouldn't it be completely invisible on white box thumbnails? I'll attach screenshot to give you an idea. ::: src/collection-view.vala @@ +40,3 @@ + public static const Gdk.RGBA SMALL_EMBLEM_COLOR = { 1.0, 1.0, 1.0, 1.0 }; + public static const int SMALL_EMBLEM_SIZE = 16; + public static const int SMALL_EMBLEM_PADDING = 8; static is implied with const afaik. @@ +100,3 @@ + return pixbuf; + + const Gtk.CornerType[] right_corner = { Gtk.CornerType.TOP_RIGHT, Gtk.CornerType.BOTTOM_RIGHT }; Please declare constants are class-wide above. @@ +102,3 @@ + const Gtk.CornerType[] right_corner = { Gtk.CornerType.TOP_RIGHT, Gtk.CornerType.BOTTOM_RIGHT }; + double offset_x = corner_type in right_corner ? pixbuf.width - emblem.width - SMALL_EMBLEM_PADDING : + SMALL_EMBLEM_PADDING; why do these need to be double? They are passed as ints below.
Created attachment 305920 [details] Screenshot of star over (almost) white thumbnails This screenshot isn't exactly perfectly showing the issue since thumbnails happen to not take all the height available to them but you get the idea.
Created attachment 306069 [details] [review] collection-view: Improve favorites emblem This moves the "favorites" emblem to the bottom left corner of the thumbnails and draws it as a small star instead of a big heart. This is needed to comply to GNOME's HIG and to make sure the "favorites" emblem don't conflict with the item's selection checkbox.
Review of attachment 306069 [details] [review]: Two logical changes, aren't they? You know what i'm getting to.. :)
You mean using the starred icon and putting it on the bottom left side? Drawing the emblem where we want it and at the size we want it required to rewrite totally how emblems are handled, is it worthy to make a commit just to replace "favorite-emblem" by "starred-symbolic" when the code has been totally changed?
(In reply to Adrien Plazas from comment #7) > You mean using the starred icon and putting it on the bottom left side? Yes. > Drawing the emblem where we want it and at the size we want it required to > rewrite totally how emblems are handled, is it worthy to make a commit just > to replace "favorite-emblem" by "starred-symbolic" when the code has been > totally changed? I see what you mean but it won't be hard to first change the placing of the icon and then change how its drawn?
Created attachment 306098 [details] [review] collection-view: Move favorites emblem This moves the "favorites" emblem to the bottom left corner of the thumbnails and draws it small. This is needed to comply to GNOME's HIG and to make sure the "favorites" emblem don't conflict with the item's selection checkbox.
Created attachment 306099 [details] [review] collection-view: Change favorites emblem shape This replaces the "emblem-favorite" icon by the "starred" icon as the emblem for favorite boxes. This is needed to comply to GNOME's HIG.
Review of attachment 306099 [details] [review]: Looks good. * "collection-view: Favorite emblem now a star" would be more specific shortlog. * Just for future ref, it'll save you some typing if you assume yourself to be the patch :) "This replaces.." -> "Replace..".
Review of attachment 306098 [details] [review]: Great but shortlog could be more specific: "Move favorite emblem to bottom left" or just "Favorite emblem to bottom left".
Created attachment 306104 [details] [review] collection-view: Favorite emblem to bottom left This moves the "favorites" emblem to the bottom left corner of the thumbnails and draws it small. This is needed to comply to GNOME's HIG and to make sure the "favorites" emblem don't conflict with the item's selection checkbox.
Created attachment 306105 [details] [review] collection-view: Favorites emblem now a star Replace the "emblem-favorite" icon by the "starred" icon as the emblem for favorite boxes. This is needed to comply to GNOME's HIG.
Attachment 306104 [details] pushed as 8fd7955 - collection-view: Favorite emblem to bottom left Attachment 306105 [details] pushed as e8803fc - collection-view: Favorites emblem now a star