GNOME Bugzilla – Bug 745625
[PATCHes] Use GResource and GtkBuilder.
Last modified: 2015-03-31 17:05:42 UTC
Created attachment 298556 [details] [review] Bump Gtk+ required version to 3.15.0. That’s not completely needed for now, as the code is steel quite simple, but it would be a good idea anyway to use GResource and GtkBuilder. Here are four patches: * the first bumps Gtk+ version to 3.15.0, not completely needed but that’s a facility to test CSS resources; * the second loads the app-menu from GResource; * the third uses GtkBuilder for the main window; * and the last one only clean spaces errors.
Created attachment 298557 [details] [review] Use GResource for loading the app-menu.
Created attachment 298558 [details] [review] Use GtkBuilder.
Created attachment 298559 [details] [review] Remove spaces.
Thanks for the patches. I guess they can wait until 3.16.0 is officially out, as this is not strictly required, and it'd be nice to have some testing on this.
Yeps, no hurry.
Attachment 298557 [details] pushed as f3d6134 - Use GResource for loading the app-menu. Attachment 298558 [details] pushed as 9424525 - Use GtkBuilder. Attachment 298559 [details] pushed as 35e01db - Remove spaces. I'm leaving the GTK version bump for after the Fedora 22 official release, which will include GTK 3.16. I've pushed the other patches and they'll appear in the first unstable tarball for 3.17.
I don’t understand what you have in mind, a gtk+ bump is probably needed anyway for loading the app-menu with GResource.
(In reply to Arnaud Bonatti from comment #7) > I don’t understand what you have in mind, a gtk+ bump is probably needed > anyway for loading the app-menu with GResource. Not really, the appmenu is loaded and working for me without the GTK+ version bump, lightsoff is compiling and running without the bump. BTW you have already mentioned in the desciption, "the first bumps Gtk+ version to 3.15.0, not completely needed but that’s a facility to test CSS resources;".
Switching to (now no more) unstable Gtk+ is unnecessary (I don’t load CSS), but I don’t bump if that’s not needed. GtkApplication “tries to load menus from resources” beginning with 3.13.4.
(In reply to Arnaud Bonatti from comment #9) > Switching to (now no more) unstable Gtk+ is unnecessary For me it boils down to being able to develop on my existing systems without jhbuild as much as possible (of course, apps which require features I don't have locally will be built with JHBuild), as a local build takes considerably less then a JHBuild. GTK+ 3.16.0 might be out already, but there's no stable operating system coming with it (Arch is one, and the GNOME 3.16.0 ISO is another one), that will only happen in one month, with Fedora 22, as far as I know. But of course, if a maintainer decides that the version bump is required, I will obey, and will live with the games being built in JHBuild. > (I don’t load CSS), I saw that iagno does that, and I am aware that the bump was required there. > but I don’t bump if that’s not needed. OK, then we agree on this. > GtkApplication “tries to load menus > from resources” beginning with 3.13.4. I guess that is why it does work for me.
Robert... in the universe I live in, you are the maintainer. But I guess I'm in the wrong universe, because indeed you're not listed in the doap file. Thomas isn't working on GNOME games anymore; you can replace his name with your own. That would make sense for all the games you release. The expectations for being a maintainer are to handle releases and look at bugs, i.e. the stuff you're already doing now, so no change. Anyway, sounds like 3.16 is definitely not needed, so you can bump the version to 3.14 or 3.13.4 if you want to be that specific, and move on. :)
I pushed such a patch on master, closing.